[Asterisk-code-review] res_stir_shaken: Add unit tests for signing and verification. (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14408 )

Change subject: res_stir_shaken: Add unit tests for signing and verification.
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14408/3/res/res_stir_shaken/certificate.c 
File res/res_stir_shaken/certificate.c:

https://gerrit.asterisk.org/c/asterisk/+/14408/3/res/res_stir_shaken/certificate.c@267 
PS3, Line 267: 	res = ast_sorcery_delete(sorcery, cert);
             : 	if (res) {
             : 		ast_log(LOG_ERROR, "Failed to delete sorcery object with caller ID "
             : 			"'%s'\n", caller_id_number);
             : 		return -1;
             : 	}
             : 	ao2_cleanup(cert)
The off nominal path has a leak on "cert". You can move the cleanup to just after the delete call to avoid it.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14408
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9fa43380f861ccf710cd0f6b6c102a517c86ea13
Gerrit-Change-Number: 14408
Gerrit-PatchSet: 3
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 19 May 2020 18:09:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200519/612aa8fb/attachment-0001.html>