[Asterisk-code-review] res_pjsip_nat.c: remove x-ast-orig-host from request URI and To header (asterisk[16])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14406 )

Change subject: res_pjsip_nat.c: remove x-ast-orig-host from request URI and To header
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14406/1/res/res_pjsip_nat.c 
File res/res_pjsip_nat.c:

https://gerrit.asterisk.org/c/asterisk/+/14406/1/res/res_pjsip_nat.c@317 
PS1, Line 317: while ((x_orig_host = pjsip_param_find(&uri->other_param, &x_name))) {
             : 				pj_list_erase(x_orig_host);
             : 			}
> To avoid any discussion and try to avoid to do the same work 4 times (as I am not working daily with […]
makes sense. I think in this case the code could be reduced a bit by using the pjsip calls instead. But that said totally optional.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14406
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Id032b33098a1befea9b243ca994184baecccc59e
Gerrit-Change-Number: 14406
Gerrit-PatchSet: 1
Gerrit-Owner: nappsoft <infos at nappsoft.ch>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 19 May 2020 17:50:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: nappsoft <infos at nappsoft.ch>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200519/70a06a69/attachment.html>