[Asterisk-code-review] Scope Tracing: A new facility for tracing scope enter/exit (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14414 )

Change subject: Scope Tracing:  A new facility for tracing scope enter/exit
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/14414/1/configs/samples/logger.conf.sample 
File configs/samples/logger.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/14414/1/configs/samples/logger.conf.sample@150 
PS1, Line 150: Debug
             : ; messages are also very verbose and can and do fill up logfiles quickly;
             : ; this is another reason not to have debug mode on a production system unless
             : ; you are in the process of debugging a specific issue.
> I'd say add a note here, or specify "Debug and trace...", about trace's potential effect on one's system load.

Good point.


https://gerrit.asterisk.org/c/asterisk/+/14414/1/main/cli.c 
File main/cli.c:

https://gerrit.asterisk.org/c/asterisk/+/14414/1/main/cli.c@664 
PS1, Line 664: 			ml = find_module_level(mod, &debug_modules);
> What happens here if both debug and trace levels are specified for a given module name? For instance, it seems like it could remove the debug module for debugging, and then add the trace one. But then you'd lose the debug level? And vice versa in the similar debug level code?

good point.  i'm going to use a separate list for trace.


https://gerrit.asterisk.org/c/asterisk/+/14414/1/main/cli.c@716 
PS1, Line 716: 		AST_RWLIST_WRLOCK(&debug_modules);
             : 		while ((ml = AST_RWLIST_REMOVE_HEAD(&debug_modules, entry))) {
             : 			ast_free(ml);
             : 		}
> This removes all debug modules as well thus wiping out any debug levels set for those modules.

Yep, see above.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14414
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic5ebb859883f9c10a08c5630802de33500cad027
Gerrit-Change-Number: 14414
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 19 May 2020 16:32:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200519/6e3df3e8/attachment-0001.html>