[Asterisk-code-review] res_pjsip_logger: Expand functionality to improve logging. (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14410 )

Change subject: res_pjsip_logger: Expand functionality to improve logging.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14410/2/res/res_pjsip_logger.c 
File res/res_pjsip_logger.c:

https://gerrit.asterisk.org/c/asterisk/+/14410/2/res/res_pjsip_logger.c@116 
PS2, Line 116: 	/*! \brief Whether to log to console or not */
             : 	unsigned int log_to_console:1;
I think this should be renamed to something else as it doesn't just log to console, but to any logging channel set up to allow verbose messages. Maybe just log_to_verbose? or just log_verbose?. And then the option would change to pjsip set logger verbose.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14410
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: If5859161a72b0d7dd2d1f92d45bed88e0cd07d0e
Gerrit-Change-Number: 14410
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 18 May 2020 22:22:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200518/2f925dc4/attachment.html>