[Asterisk-code-review] res_pjsip_nat.c: remove x-ast-orig-host from request URI and To header (asterisk[16])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14406 )

Change subject: res_pjsip_nat.c: remove x-ast-orig-host from request URI and To header
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/14406/1/res/res_pjsip_nat.c 
File res/res_pjsip_nat.c:

https://gerrit.asterisk.org/c/asterisk/+/14406/1/res/res_pjsip_nat.c@317 
PS1, Line 317: while ((x_orig_host = pjsip_param_find(&uri->other_param, &x_name))) {
             : 				pj_list_erase(x_orig_host);
             : 			}
Any reason for the "while" here vs. using the pjsip "pjsip_param_find" function? Can the parameter be included multiple times?

Same below when looking for it in the To header?


https://gerrit.asterisk.org/c/asterisk/+/14406/1/res/res_pjsip_nat.c@321 
PS1, Line 321: for (hdr = tdata->msg->hdr.next; hdr != &tdata->msg->hdr; hdr = hdr->next) {
             : 			if (hdr->type == PJSIP_H_TO) {
Similar question but any reason to not use the "pjsip_msg_find_hdr", or PJSIP_MSG_TO_HDR macro, call vs the for loop?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14406
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Id032b33098a1befea9b243ca994184baecccc59e
Gerrit-Change-Number: 14406
Gerrit-PatchSet: 1
Gerrit-Owner: nappsoft <infos at nappsoft.ch>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 18 May 2020 21:49:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200518/7e4cf623/attachment.html>