[Asterisk-code-review] pjproject: Upgrade bundled version to pjproject 2.10 (asterisk[16])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14413 )

Change subject: pjproject: Upgrade bundled version to pjproject 2.10
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/14413/2/include/asterisk/res_pjsip.h 
File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/c/asterisk/+/14413/2/include/asterisk/res_pjsip.h@62 
PS2, Line 62: #define PJSIP_EXPIRES_NOT_SPECIFIED	((pj_uint32_t)0xFFFFFFFFUL)
((pj_uint32_t) -1)

Would be clearer and likely safer when using older versions of pjproject.


https://gerrit.asterisk.org/c/asterisk/+/14413/2/res/res_pjsip_outbound_publish.c 
File res/res_pjsip_outbound_publish.c:

https://gerrit.asterisk.org/c/asterisk/+/14413/2/res/res_pjsip_outbound_publish.c@1323 
PS2, Line 1323: 		if (!expires || expires->ivalue == PJSIP_EXPIRES_NOT_SPECIFIED) {
This is not equivalent for old versions. 0 vs -1


https://gerrit.asterisk.org/c/asterisk/+/14413/2/res/res_pjsip_pubsub.c 
File res/res_pjsip_pubsub.c:

https://gerrit.asterisk.org/c/asterisk/+/14413/2/res/res_pjsip_pubsub.c@4228 
PS2, Line 4228: 	if (expiry < 0) {
test is never true now that expiry is unsigned.

In this case expiry should not be changed to unsigned.  You can return the value as unsigned once you have determined that expiry is not negative.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14413
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Iec8821c6cbbc08c369d0e3cd2f14e691b41d0c81
Gerrit-Change-Number: 14413
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 18 May 2020 21:13:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200518/f2f0e4fb/attachment-0001.html>