[Asterisk-code-review] res_pjsip_logger: Expand functionality to improve logging. (asterisk[13])

Joshua Colp asteriskteam at digium.com
Fri May 15 06:03:52 CDT 2020


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14410 )

Change subject: res_pjsip_logger: Expand functionality to improve logging.
......................................................................


Patch Set 2:

To answer some likely questions:

I didn't use libpcap because it would add another dependency, and it would only provide a small segment of functionality for this. We'd end up constructing everything but the PCAP headers.

Opinions on the CLI commands would be nice.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14410
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: If5859161a72b0d7dd2d1f92d45bed88e0cd07d0e
Gerrit-Change-Number: 14410
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Comment-Date: Fri, 15 May 2020 11:03:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200515/e941a51b/attachment.html>


More information about the asterisk-code-review mailing list