[Asterisk-code-review] res_musiconhold: Added check for dot character in path of playlist en... (asterisk[16])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14407 )

Change subject: res_musiconhold: Added check for dot character in path of playlist entries to avoid warnings
......................................................................


Patch Set 2: Code-Review+1

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > > Patch Set 1:
> > > 
> > > You are right. At this point we do not need the exact position just a relative one. But why to test on last_pos_dot within the if condition in first place? Anyhow, I like the performance improvement:-)
> > 
> > You mean skipping the NULL check, like:
> > 
> >  if (last_pos_dot > last_pos_slash) {
> > 
> > That works for me as long as it compiles.
> 
> Sorry, no. You meant doing the null check as a 'one liner'. I did it explicit before for more readability. But I am with you and will run the test shortly with your suggestion. Thanks


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14407
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I2ec35a613413affbf5fcc01c8c181eba24865b9e
Gerrit-Change-Number: 14407
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas John Koch <koch at njk-it.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 14 May 2020 13:01:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200514/7d794513/attachment.html>