[Asterisk-code-review] res_musiconhold: Added check for dot character in path of playlist en... (asterisk[16])

Sean Bright asteriskteam at digium.com
Wed May 13 15:01:00 CDT 2020


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14407 )

Change subject: res_musiconhold: Added check for dot character in path of playlist entries to avoid warnings
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14407/1/res/res_musiconhold.c 
File res/res_musiconhold.c:

https://gerrit.asterisk.org/c/asterisk/+/14407/1/res/res_musiconhold.c@1094 
PS1, Line 1094: 					if (last_pos_dot != NULL) {
How about just:

 if (last_pos_dot && last_pos_dot > last_pos_slash) {
    ast_log(...)
 }



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14407
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I2ec35a613413affbf5fcc01c8c181eba24865b9e
Gerrit-Change-Number: 14407
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas John Koch <koch at njk-it.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 13 May 2020 20:01:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200513/939e52c7/attachment.html>


More information about the asterisk-code-review mailing list