[Asterisk-code-review] res_pjsip: Add endpoint configuration -- log_subscription_error (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14405 )

Change subject: res_pjsip:  Add endpoint configuration -- log_subscription_error
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14405/2/res/res_pjsip_exten_state.c 
File res/res_pjsip_exten_state.c:

https://gerrit.asterisk.org/c/asterisk/+/14405/2/res/res_pjsip_exten_state.c@419 
PS2, Line 419: 			ast_log(LOG_NOTICE, "Endpoint '%s' state subscription failed: "
             : 				"Extension '%s' does not exist in context '%s' or has no associated hint\n",
             : 				ast_sorcery_object_get_id(endpoint), resource, context);
> I think it's better to actually start to invent a new log paradigm altogether that's more flag orien […]
I agree that having the ability to control at a finer level log messages would be nice, as log levels really do end up being a deployment/personal perspective. My concern with this interim approach is that it can grow out of control. An option to control this log message, then this one, then this one, then this one. Once it's added then we maintain it, and it can end up becoming an expectation that people have for new log messages.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14405
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5dff21c3c8ac3a3e3aefbd89053581fb90bc7018
Gerrit-Change-Number: 14405
Gerrit-PatchSet: 2
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 12 May 2020 09:17:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Comment-In-Reply-To: Mark Murawski <markm at intellasoft.net>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200512/ceb5b801/attachment.html>