[Asterisk-code-review] res_pjsip: Add endpoint configuration -- log_subscription_error (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14405 )

Change subject: res_pjsip:  Add endpoint configuration -- log_subscription_error
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14405/2/res/res_pjsip_exten_state.c 
File res/res_pjsip_exten_state.c:

https://gerrit.asterisk.org/c/asterisk/+/14405/2/res/res_pjsip_exten_state.c@419 
PS2, Line 419: 			ast_log(LOG_NOTICE, "Endpoint '%s' state subscription failed: "
             : 				"Extension '%s' does not exist in context '%s' or has no associated hint\n",
             : 				ast_sorcery_object_get_id(endpoint), resource, context);
Instead of adding a whole new option just for this one log statement I think I'd be more inclined for this patch to change the log level from a LOG_NOTICE to a verbose log message level 1:

ast_verb(1, "....");

However, don't change things yet though. I'd like to get your's and other's thoughts on doing that vs. what you have currently first.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14405
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5dff21c3c8ac3a3e3aefbd89053581fb90bc7018
Gerrit-Change-Number: 14405
Gerrit-PatchSet: 2
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 11 May 2020 21:05:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200511/faa38444/attachment-0001.html>