[Asterisk-code-review] res_pjsip_history.c: Fix to stop SIGSEGV when IPv6 addresses are enco... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14402 )

Change subject: res_pjsip_history.c: Fix to stop SIGSEGV when IPv6 addresses are encountered.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14402/1/res/res_pjsip_history.c 
File res/res_pjsip_history.c:

https://gerrit.asterisk.org/c/asterisk/+/14402/1/res/res_pjsip_history.c@67 
PS1, Line 67: union {
            : 		pj_sockaddr_in src;
            : 		pj_sockaddr_in src6;
            : 	};
How does this help?  You have not increased the size of the members for IPv6 addresses because the types are the same.

Also this is just a definition change where nothing references the new members.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14402
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3579e0b806119fd922e11da35f4b2dbda4a1a4ca
Gerrit-Change-Number: 14402
Gerrit-PatchSet: 1
Gerrit-Owner: Roger James <roger at beardandsandals.co.uk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 08 May 2020 22:08:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200508/e30540f8/attachment.html>