[Asterisk-code-review] pjproject: Fix race condition when building with parallel make (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14401 )

Change subject: pjproject: Fix race condition when building with parallel make
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1: Code-Review-1
> > 
> > Hi Guido.  I see you submitted a pull request to pjproject for this.  That's great!
> > https://github.com/pjsip/pjproject/pull/2426
> > 
> > I'm marking these reviews -1 temporarily until they've accepted the pull request.
> > When they do, can you replace the patch file with "git show" for that commit so we have the commit message and hash from the pjproject repo?
> 
> Unluckily the patch present in the pull request is against pjproject 2.10 sources, the patch required for pjproject 2.9 bundled in asterisk is slightly different.
> 
> Anyway I can grab that patch and manually adapt it, keeping the headers. If this is acceptable.
> 
> > 
> > In the mean time, we'll let them know that you're an Asterisk contributor which should speed up the process.
> 
> Thanks. I'm also going to include these patches in the FreeBSD asterisk ans pjsip ports. These are used by many FreeBSD users.

How about if you just copy the text header part of the "git show" that has the commit, date, commit message etc. into the current patch file.  That way we'll at least know it made it into the pjproject repo.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14401
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ie1b0dc365dafe4a84c5248097fe8d73804043c22
Gerrit-Change-Number: 14401
Gerrit-PatchSet: 1
Gerrit-Owner: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 08 May 2020 16:05:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200508/3b802839/attachment.html>