[Asterisk-code-review] codec_negotiation: Implement SDP answer preferences (asterisk[master])

[George Joseph]

Hello Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/14328

to look at the new patch set (#3).

Change subject: codec_negotiation: Implement SDP answer preferences
......................................................................

codec_negotiation: Implement SDP answer preferences

* Added outgoing_call_answer_pref and incoming_call_answer_pref
  to structures, endpoint config, and sample pjsip.conf.

* Added a new function ast_sip_session_create_joint_cap_from_stream
  which takes a stream from pending topology and the capabilities
  of the peer and creates the joint caps.

* Refactored get_codecs() in res_pjsip_sdp_rtp.c so it preserves
  the order or codecs specified on SDP "m" attributes.

* Updated set_caps() and set_incoming_call_offer_cap() in
  res_pjsip_sdp_rtp.c to use the new codec functions.

* Slightly refactored the ast_sip_call_codec_str_to_pref function
  in res_pjsip.

* Added a new function ast_sip_session_get_name which can be used
  to get a meaningful name for error/warning/debug messages.
  If a session->channel is not NULL, it returns the channel
  name.  Then it checks session->endpoint and if not NULL,
  returns the endpoint's sorcery id.  If all else fails, it
  returns "unknown".

* Added a lot of debug messages to res_pjsip_session and
  res_pjsip_sdp_rtp.

ASTERISK-28856

Change-Id: Iad188ae997bdcb5c28e2eb12c6bb2b732538ad45
---
M configs/samples/pjsip.conf.sample
M include/asterisk/res_pjsip.h
M include/asterisk/res_pjsip_session.h
M include/asterisk/res_pjsip_session_caps.h
M res/res_pjsip.c
M res/res_pjsip/pjsip_configuration.c
M res/res_pjsip_sdp_rtp.c
M res/res_pjsip_session.c
M res/res_pjsip_session/pjsip_session_caps.c
9 files changed, 380 insertions(+), 87 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/28/14328/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14328
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iad188ae997bdcb5c28e2eb12c6bb2b732538ad45
Gerrit-Change-Number: 14328
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200504/4f7ba75c/attachment.html>