[Asterisk-code-review] core: Fix NPE in ast_manager_build_channel_state_string when snapshot... (asterisk[16])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14144 )

Change subject: core: Fix NPE in ast_manager_build_channel_state_string when snapshot is NULL
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> > 
> > This seems an appealing middle ground to me, is there a consensus that this would be acceptable?
> > 
>  
> 
> Gerrit didn't give my prior comment the context I thought it would, so to clarify it was in response to:
> 
> Maybe we could use __ast_assert_failed here instead?  In normal production builds (without DO_CRASH) this would log a frack and backtrace instead of crashing.

I think you should do that in your environment and when you have a usable backtrace we can revisit this. That is my 2 cents.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14144
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I3393e4d521ab6c4551b5434d013a5941706c28de
Gerrit-Change-Number: 14144
Gerrit-PatchSet: 3
Gerrit-Owner: Robert Sutton <rsutton at noojee.com.au>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-CC: Corey Farrell <git at cfware.com>
Gerrit-Comment-Date: Fri, 01 May 2020 14:34:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200501/f8446547/attachment.html>