[Asterisk-code-review] bridges/softmix_unhold: Wait to create second channel. (testsuite[certified/16.8])

Friendly Automation asteriskteam at digium.com
Fri May 1 07:28:07 CDT 2020


Friendly Automation has submitted this change. ( https://gerrit.asterisk.org/c/testsuite/+/14368 )

Change subject: bridges/softmix_unhold: Wait to create second channel.
......................................................................

bridges/softmix_unhold: Wait to create second channel.

This test exposed a bug detailed at ASTERISK~28862
which exhibits itself when MOH is started and stopped
between two threads. There is a race condition
where the MOH is not actually stopped even when it
should be.

Until the issue is resolved this change adds a delay
to ensure that MOH has actually started and is flowing
before proceeding.

Change-Id: I64ed5ff8b9e7e1d2f704e01b72ad3ed240f2f20b
---
M tests/rest_api/bridges/softmix_unhold/test-config.yaml
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/tests/rest_api/bridges/softmix_unhold/test-config.yaml b/tests/rest_api/bridges/softmix_unhold/test-config.yaml
index a85b119..65b8de6 100644
--- a/tests/rest_api/bridges/softmix_unhold/test-config.yaml
+++ b/tests/rest_api/bridges/softmix_unhold/test-config.yaml
@@ -93,6 +93,8 @@
             count: 1
         ari-requests:
             -
+                # This delay is to work around ASTERISK-28862 for the moment
+                delay: 2
                 method: 'post'
                 uri: 'channels'
                 params:

-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/14368
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: certified/16.8
Gerrit-Change-Id: I64ed5ff8b9e7e1d2f704e01b72ad3ed240f2f20b
Gerrit-Change-Number: 14368
Gerrit-PatchSet: 3
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200501/38d176ee/attachment-0001.html>


More information about the asterisk-code-review mailing list