[Asterisk-code-review] pjsip/resolver: Limit codec usage to ulaw. (testsuite[master])

Joshua Colp asteriskteam at digium.com
Fri May 1 07:27:31 CDT 2020 

Joshua Colp has submitted this change. ( https://gerrit.asterisk.org/c/testsuite/+/14359 )

Change subject: pjsip/resolver: Limit codec usage to ulaw.
......................................................................

pjsip/resolver: Limit codec usage to ulaw.

In some executions a re-INVITE was slipping
in to change the codecs in use. By limiting
to ulaw only we ensure this can not happen.

Change-Id: Ie43ba62094ef521e76def4295f5790ec1ed2907d
---
M tests/channels/pjsip/resolver/a/configs/ast1/pjsip.conf
M tests/channels/pjsip/resolver/aaaa/configs/ast1/pjsip.conf
M tests/channels/pjsip/resolver/naptr/explicit_transport_configured/configs/ast1/pjsip.conf
M tests/channels/pjsip/resolver/naptr/order/configs/ast1/pjsip.conf
M tests/channels/pjsip/resolver/naptr/preference/configs/ast1/pjsip.conf
M tests/channels/pjsip/resolver/naptr/preference_failover/configs/ast1/pjsip.conf
M tests/channels/pjsip/resolver/naptr/restricted_transport/configs/ast1/pjsip.conf
M tests/channels/pjsip/resolver/naptr/transport_tcp/configs/ast1/pjsip.conf
M tests/channels/pjsip/resolver/naptr/transport_udp/configs/ast1/pjsip.conf
M tests/channels/pjsip/resolver/naptr/transport_unspecified/configs/ast1/pjsip.conf
M tests/channels/pjsip/resolver/srv/explicit_transport_configured/configs/ast1/pjsip.conf
M tests/channels/pjsip/resolver/srv/failover/in_dialog/timeout/configs/ast1/pjsip.conf
M tests/channels/pjsip/resolver/srv/failover/in_dialog/transport_tcp/configs/ast1/pjsip.conf
M tests/channels/pjsip/resolver/srv/failover/in_dialog/transport_udp/configs/ast1/pjsip.conf
M tests/channels/pjsip/resolver/srv/failover/in_dialog/transport_unspecified/configs/ast1/pjsip.conf
M tests/channels/pjsip/resolver/srv/priority/configs/ast1/pjsip.conf
M tests/channels/pjsip/resolver/srv/transport_tcp/configs/ast1/pjsip.conf
M tests/channels/pjsip/resolver/srv/transport_udp/configs/ast1/pjsip.conf
M tests/channels/pjsip/resolver/srv/transport_unspecified/configs/ast1/pjsip.conf
19 files changed, 20 insertions(+), 20 deletions(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Joshua Colp: Approved for Submit



diff --git a/tests/channels/pjsip/resolver/a/configs/ast1/pjsip.conf b/tests/channels/pjsip/resolver/a/configs/ast1/pjsip.conf
index 55be51f..7cf7e3d 100644
--- a/tests/channels/pjsip/resolver/a/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/resolver/a/configs/ast1/pjsip.conf
@@ -11,4 +11,4 @@
 [jenny]
 type=endpoint
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw
diff --git a/tests/channels/pjsip/resolver/aaaa/configs/ast1/pjsip.conf b/tests/channels/pjsip/resolver/aaaa/configs/ast1/pjsip.conf
index 0ac1b60..c471b7c 100644
--- a/tests/channels/pjsip/resolver/aaaa/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/resolver/aaaa/configs/ast1/pjsip.conf
@@ -11,4 +11,4 @@
 [jenny]
 type=endpoint
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw
diff --git a/tests/channels/pjsip/resolver/naptr/explicit_transport_configured/configs/ast1/pjsip.conf b/tests/channels/pjsip/resolver/naptr/explicit_transport_configured/configs/ast1/pjsip.conf
index 4035a5b..da0e324 100644
--- a/tests/channels/pjsip/resolver/naptr/explicit_transport_configured/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/resolver/naptr/explicit_transport_configured/configs/ast1/pjsip.conf
@@ -18,4 +18,4 @@
 transport=transport-ipv6-udp
 from_user=forrest
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw
diff --git a/tests/channels/pjsip/resolver/naptr/order/configs/ast1/pjsip.conf b/tests/channels/pjsip/resolver/naptr/order/configs/ast1/pjsip.conf
index 4f2b4e1..90e9815 100644
--- a/tests/channels/pjsip/resolver/naptr/order/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/resolver/naptr/order/configs/ast1/pjsip.conf
@@ -11,4 +11,4 @@
 [rick]
 type=endpoint
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw
diff --git a/tests/channels/pjsip/resolver/naptr/preference/configs/ast1/pjsip.conf b/tests/channels/pjsip/resolver/naptr/preference/configs/ast1/pjsip.conf
index 4f2b4e1..90e9815 100644
--- a/tests/channels/pjsip/resolver/naptr/preference/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/resolver/naptr/preference/configs/ast1/pjsip.conf
@@ -11,4 +11,4 @@
 [rick]
 type=endpoint
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw
diff --git a/tests/channels/pjsip/resolver/naptr/preference_failover/configs/ast1/pjsip.conf b/tests/channels/pjsip/resolver/naptr/preference_failover/configs/ast1/pjsip.conf
index f46190b..b116aa0 100644
--- a/tests/channels/pjsip/resolver/naptr/preference_failover/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/resolver/naptr/preference_failover/configs/ast1/pjsip.conf
@@ -16,4 +16,4 @@
 [rick]
 type=endpoint
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw
diff --git a/tests/channels/pjsip/resolver/naptr/restricted_transport/configs/ast1/pjsip.conf b/tests/channels/pjsip/resolver/naptr/restricted_transport/configs/ast1/pjsip.conf
index a44a43e..fa1ed3f 100644
--- a/tests/channels/pjsip/resolver/naptr/restricted_transport/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/resolver/naptr/restricted_transport/configs/ast1/pjsip.conf
@@ -11,4 +11,4 @@
 [rick]
 type=endpoint
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw
diff --git a/tests/channels/pjsip/resolver/naptr/transport_tcp/configs/ast1/pjsip.conf b/tests/channels/pjsip/resolver/naptr/transport_tcp/configs/ast1/pjsip.conf
index 3355d03..0921b9b 100644
--- a/tests/channels/pjsip/resolver/naptr/transport_tcp/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/resolver/naptr/transport_tcp/configs/ast1/pjsip.conf
@@ -11,4 +11,4 @@
 [jenny]
 type=endpoint
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw
diff --git a/tests/channels/pjsip/resolver/naptr/transport_udp/configs/ast1/pjsip.conf b/tests/channels/pjsip/resolver/naptr/transport_udp/configs/ast1/pjsip.conf
index 2d98347..bf85d49 100644
--- a/tests/channels/pjsip/resolver/naptr/transport_udp/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/resolver/naptr/transport_udp/configs/ast1/pjsip.conf
@@ -16,4 +16,4 @@
 [jenny]
 type=endpoint
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw
diff --git a/tests/channels/pjsip/resolver/naptr/transport_unspecified/configs/ast1/pjsip.conf b/tests/channels/pjsip/resolver/naptr/transport_unspecified/configs/ast1/pjsip.conf
index 3355d03..0921b9b 100644
--- a/tests/channels/pjsip/resolver/naptr/transport_unspecified/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/resolver/naptr/transport_unspecified/configs/ast1/pjsip.conf
@@ -11,4 +11,4 @@
 [jenny]
 type=endpoint
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw
diff --git a/tests/channels/pjsip/resolver/srv/explicit_transport_configured/configs/ast1/pjsip.conf b/tests/channels/pjsip/resolver/srv/explicit_transport_configured/configs/ast1/pjsip.conf
index 4035a5b..da0e324 100644
--- a/tests/channels/pjsip/resolver/srv/explicit_transport_configured/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/resolver/srv/explicit_transport_configured/configs/ast1/pjsip.conf
@@ -18,4 +18,4 @@
 transport=transport-ipv6-udp
 from_user=forrest
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw
diff --git a/tests/channels/pjsip/resolver/srv/failover/in_dialog/timeout/configs/ast1/pjsip.conf b/tests/channels/pjsip/resolver/srv/failover/in_dialog/timeout/configs/ast1/pjsip.conf
index 4599b1e..56e96a5 100644
--- a/tests/channels/pjsip/resolver/srv/failover/in_dialog/timeout/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/resolver/srv/failover/in_dialog/timeout/configs/ast1/pjsip.conf
@@ -16,4 +16,4 @@
 [jenny]
 type=endpoint
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw
diff --git a/tests/channels/pjsip/resolver/srv/failover/in_dialog/transport_tcp/configs/ast1/pjsip.conf b/tests/channels/pjsip/resolver/srv/failover/in_dialog/transport_tcp/configs/ast1/pjsip.conf
index 9f2e92b..406d8be 100644
--- a/tests/channels/pjsip/resolver/srv/failover/in_dialog/transport_tcp/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/resolver/srv/failover/in_dialog/transport_tcp/configs/ast1/pjsip.conf
@@ -6,4 +6,4 @@
 [jenny]
 type=endpoint
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw
diff --git a/tests/channels/pjsip/resolver/srv/failover/in_dialog/transport_udp/configs/ast1/pjsip.conf b/tests/channels/pjsip/resolver/srv/failover/in_dialog/transport_udp/configs/ast1/pjsip.conf
index 4730a92..3ec2868 100644
--- a/tests/channels/pjsip/resolver/srv/failover/in_dialog/transport_udp/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/resolver/srv/failover/in_dialog/transport_udp/configs/ast1/pjsip.conf
@@ -11,4 +11,4 @@
 [jenny]
 type=endpoint
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw
diff --git a/tests/channels/pjsip/resolver/srv/failover/in_dialog/transport_unspecified/configs/ast1/pjsip.conf b/tests/channels/pjsip/resolver/srv/failover/in_dialog/transport_unspecified/configs/ast1/pjsip.conf
index 2cd1367..f96ab07 100644
--- a/tests/channels/pjsip/resolver/srv/failover/in_dialog/transport_unspecified/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/resolver/srv/failover/in_dialog/transport_unspecified/configs/ast1/pjsip.conf
@@ -16,4 +16,4 @@
 [jenny]
 type=endpoint
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw
diff --git a/tests/channels/pjsip/resolver/srv/priority/configs/ast1/pjsip.conf b/tests/channels/pjsip/resolver/srv/priority/configs/ast1/pjsip.conf
index cc521c3..0485b67 100644
--- a/tests/channels/pjsip/resolver/srv/priority/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/resolver/srv/priority/configs/ast1/pjsip.conf
@@ -18,11 +18,11 @@
 transport=transport-ipv4-udp
 from_user=jenny
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw
 
 [forrest]
 type=endpoint
 transport=transport-ipv6-udp
 from_user=forrest
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw
diff --git a/tests/channels/pjsip/resolver/srv/transport_tcp/configs/ast1/pjsip.conf b/tests/channels/pjsip/resolver/srv/transport_tcp/configs/ast1/pjsip.conf
index 3355d03..0921b9b 100644
--- a/tests/channels/pjsip/resolver/srv/transport_tcp/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/resolver/srv/transport_tcp/configs/ast1/pjsip.conf
@@ -11,4 +11,4 @@
 [jenny]
 type=endpoint
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw
diff --git a/tests/channels/pjsip/resolver/srv/transport_udp/configs/ast1/pjsip.conf b/tests/channels/pjsip/resolver/srv/transport_udp/configs/ast1/pjsip.conf
index 2d98347..bf85d49 100644
--- a/tests/channels/pjsip/resolver/srv/transport_udp/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/resolver/srv/transport_udp/configs/ast1/pjsip.conf
@@ -16,4 +16,4 @@
 [jenny]
 type=endpoint
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw
diff --git a/tests/channels/pjsip/resolver/srv/transport_unspecified/configs/ast1/pjsip.conf b/tests/channels/pjsip/resolver/srv/transport_unspecified/configs/ast1/pjsip.conf
index 3355d03..0921b9b 100644
--- a/tests/channels/pjsip/resolver/srv/transport_unspecified/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/resolver/srv/transport_unspecified/configs/ast1/pjsip.conf
@@ -11,4 +11,4 @@
 [jenny]
 type=endpoint
 context=default
-allow=!all,ulaw,alaw,g722
+allow=!all,ulaw

-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/14359
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Change-Id: Ie43ba62094ef521e76def4295f5790ec1ed2907d
Gerrit-Change-Number: 14359
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200501/659ae479/attachment-0001.html>

More information about the asterisk-code-review mailing list