[Asterisk-code-review] dial.c: Removed dial string 80 character limitation (asterisk[master])

sungtae kim asteriskteam at digium.com
Mon Mar 30 12:38:08 CDT 2020


sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14033 )

Change subject: dial.c: Removed dial string 80 character limitation
......................................................................


Patch Set 3:

(1 comment)

Hi @joshua,

Thank you for you kind reviewing. I've fixed it. 😊

https://gerrit.asterisk.org/c/asterisk/+/14033/2/main/dial.c 
File main/dial.c:

https://gerrit.asterisk.org/c/asterisk/+/14033/2/main/dial.c@334 
PS2, Line 334: 	char numsubst[AST_MAX_DIAL_ADDR];
> I don't think numsubst is actually needed for either of these. […]
Agree, it doesn't need it.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14033
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I72c8f0319a4b47e8180817a66a7e9bde063cb330
Gerrit-Change-Number: 14033
Gerrit-PatchSet: 3
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 30 Mar 2020 17:38:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200330/085e8b9e/attachment.html>


More information about the asterisk-code-review mailing list