[Asterisk-code-review] dial.c: Added AST_MAX_DIAL_ADDR constant (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14033 )

Change subject: dial.c: Added AST_MAX_DIAL_ADDR constant
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14033/2/main/dial.c 
File main/dial.c:

https://gerrit.asterisk.org/c/asterisk/+/14033/2/main/dial.c@334 
PS2, Line 334: 	char numsubst[AST_MAX_DIAL_ADDR];
I don't think numsubst is actually needed for either of these. Both functions that take numsubst take in a (const char *) so the contents shouldn't be modified, so passing channel->device directly should be fine.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14033
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I72c8f0319a4b47e8180817a66a7e9bde063cb330
Gerrit-Change-Number: 14033
Gerrit-PatchSet: 2
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 30 Mar 2020 10:44:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200330/b14113b6/attachment.html>