[Asterisk-code-review] res_pjsip: Don't set endpoint to unavailable in all cases. (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14056 )

Change subject: res_pjsip: Don't set endpoint to unavailable in all cases.
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > > Patch Set 1:
> > > 
> > > > Patch Set 1:
> > > > 
> > > > > Patch Set 1:
> > > > > 
> > > > > (1 comment)
> > > > 
> > > > These would be improvements that could be done in another review.
> > > 
> > > What about ast_sorcery_retrieve_by_regex in this case?
> > 
> > That only operates on the endpoint name in this case, not fields.
> 
> I mean like ast_sorcery_retrieve_by_regex, but a new function ast_sorcery_retrieve_by_field_regex

I don't see anything wrong with such a thing.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14056
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I3ee00023be2393113cd4e056599f23f3499ef164
Gerrit-Change-Number: 14056
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Comment-Date: Fri, 27 Mar 2020 16:02:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200327/333137d7/attachment.html>