[Asterisk-code-review] codec_negotiation: Implement outgoing_call_offer_pref (asterisk[master])

George Joseph asteriskteam at digium.com
Thu Mar 26 13:43:03 CDT 2020


Hello Kevin Harwell, Friendly Automation, Benjamin Keith Ford, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/13945

to look at the new patch set (#10).

Change subject: codec_negotiation: Implement outgoing_call_offer_pref
......................................................................

codec_negotiation: Implement outgoing_call_offer_pref

Based on this new endpoint setting, a joint list of preferred codecs
between those received from the Asterisk core (remote), and those
specified in the endpoint's "allow" parameter (local) is created and
is used to create the outgoing SDP offer.

* Add outgoing_call_offer_pref to pjsip_configuration (endpoint)

* Add "call_direction" to res_pjsip_session.

* Update pjsip_session_caps.c to make the functions more generic
  so they could be used for both incoming and outgoing.

* Update ast_sip_session_create_outgoing to create the
  pending_media_state->topology with the results of
  ast_sip_session_create_joint_call_stream().

* The endpoint "preferred_codec_only" option now automatically sets
  AST_SIP_CALL_CODEC_PREF_FIRST in incoming_call_offer_pref.

ASTERISK-28777

Change-Id: Id4ec0b4a906c2ae5885bf947f101c59059935437
---
M configs/samples/pjsip.conf.sample
A doc/CHANGES-staging/res_pjsip_call_offer_pref.txt
D doc/CHANGES-staging/res_pjsip_incoming_call_offer_pref.txt
M include/asterisk/res_pjsip.h
M include/asterisk/res_pjsip_session.h
M include/asterisk/res_pjsip_session_caps.h
M res/res_pjsip.c
M res/res_pjsip/pjsip_configuration.c
M res/res_pjsip_sdp_rtp.c
M res/res_pjsip_session.c
M res/res_pjsip_session/pjsip_session_caps.c
11 files changed, 379 insertions(+), 292 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/45/13945/10
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13945
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Id4ec0b4a906c2ae5885bf947f101c59059935437
Gerrit-Change-Number: 13945
Gerrit-PatchSet: 10
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200326/eaffe7a1/attachment.html>


More information about the asterisk-code-review mailing list