[Asterisk-code-review] pjsip: Originate with audio and video for goog_remb test. (testsuite[master])

[Friendly Automation]

Friendly Automation has submitted this change. ( https://gerrit.asterisk.org/c/testsuite/+/14019 )

Change subject: pjsip: Originate with audio and video for goog_remb test.
......................................................................

pjsip: Originate with audio and video for goog_remb test.

This test relies on both an audio and video stream being
sent in an outgoing INVITE. When placing an outgoing call
the requested codecs are taken into account, and by default
only audio is requested. We now explicitly specify the codecs
to use resulting in both streams.

Note that this does require a starpy update.

ASTERISK-28787

Change-Id: Ib01130454a06223bb1c9fdaaa10c3d9df22c2e5d
---
M lib/python/asterisk/pluggable_modules.py
M tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/test-config.yaml
2 files changed, 4 insertions(+), 0 deletions(-)

Approvals:
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/lib/python/asterisk/pluggable_modules.py b/lib/python/asterisk/pluggable_modules.py
index dddb036..22da37e 100644
--- a/lib/python/asterisk/pluggable_modules.py
+++ b/lib/python/asterisk/pluggable_modules.py
@@ -53,6 +53,7 @@
             'async': 'False',
             'event': None,
             'timeout': None,
+            'codecs': None,
         }
 
         # process config
@@ -122,6 +123,7 @@
                                        priority=self.config['priority'],
                                        timeout=self.config['timeout'],
                                        account=self.config['account'],
+                                       codecs=self.config['codecs'],
                                        async=self.config['async'])
         else:
             defer = self.ami.originate(channel=self.config['channel'],
@@ -129,6 +131,7 @@
                                        data=self.config['data'],
                                        timeout=self.config['timeout'],
                                        account=self.config['account'],
+                                       codecs=self.config['codecs'],
                                        async=self.config['async'])
         defer.addErrback(self.failure)
 
diff --git a/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/test-config.yaml b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/test-config.yaml
index 833ac86..f6abb5b 100644
--- a/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/test-config.yaml
+++ b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/test-config.yaml
@@ -26,6 +26,7 @@
     context: 'default'
     exten: 'nowhere'
     priority: '1'
+    codecs: 'ulaw,vp9'
     trigger: 'scenario_start'
     scenario-name: 'reject.xml'
 

-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/14019
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Change-Id: Ib01130454a06223bb1c9fdaaa10c3d9df22c2e5d
Gerrit-Change-Number: 14019
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200326/1a24a329/attachment.html>