[Asterisk-code-review] codec_negotiation: Implement outgoing_call_offer_pref (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13945 )

Change subject: codec_negotiation: Implement outgoing_call_offer_pref
......................................................................


Patch Set 7:

(1 comment)

nch

https://gerrit.asterisk.org/c/asterisk/+/13945/6/include/asterisk/res_pjsip.h 
File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/c/asterisk/+/13945/6/include/asterisk/res_pjsip.h@519 
PS6, Line 519: 	/*! Union of local and remote */
             : 	AST_SIP_CALL_CODEC_PREF_INTERSECT =	1 << 0,
             : 	/*! Intersection of local and remote */
             : 	AST_SIP_CALL_CODEC_PREF_UNION =		1 << 1,
> Looks like the comments are backwards here :)

So they are!



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13945
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Id4ec0b4a906c2ae5885bf947f101c59059935437
Gerrit-Change-Number: 13945
Gerrit-PatchSet: 7
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 18:45:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Keith Ford <bford at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200325/6d88731e/attachment.html>