[Asterisk-code-review] res_stir_shaken: Initial commit and reading private key. (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13960 )

Change subject: res_stir_shaken: Initial commit and reading private key.
......................................................................


Patch Set 1: Code-Review+1

> Patch Set 1:
> 
> I have some concerns about the sorcery objects.  The commit message says "some other structure will probably be needed" but I think it should be "will be needed" 😊
> 
> I think a "callerid" object should be created who's sorcery id is the callerid with a reference to a certificate object.  This automatically makes callerid a primary key and therefore lookups much more eefficient.  The "certificate" object's id could be its signature which would facilitate lookups based on incoming identity header.  It's data could include a list of callerid that were included in the cert.

My comments were addressed successfully.  There's a follow-on task to deadl with callerid.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13960
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic4bc1416fab5d6afe15a8e2d32f7ddd4e023295f
Gerrit-Change-Number: 13960
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 15:31:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200325/412c3bff/attachment.html>