[Asterisk-code-review] test_utils: Avoid incorrect error message on load. (asterisk[16])

Joshua Colp asteriskteam at digium.com
Wed Mar 25 09:53:09 CDT 2020


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14013 )

Change subject: test_utils: Avoid incorrect error message on load.
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > What does this mean?
> > a) The code in the module is wrong because it does not adapt correctly. Or
> > b) Instead of changing AST_MODULE_INFO, MODULEINFO has to be fixed.
> 
> I think changing the MODULEINFO to contain `<depend>res_agi</depend>` and `<depend>res_crypto</depend>` would be best.

I agree.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14013
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ie007e84296bcf2bd4237f19d68ba5f932b84cd02
Gerrit-Change-Number: 14013
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Corey Farrell <git at cfware.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 14:53:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200325/cb71e8ed/attachment.html>


More information about the asterisk-code-review mailing list