[Asterisk-code-review] func_aes: Avoid incorrect error message on load. (asterisk[17])
Joshua Colp
asteriskteam at digium.com
Wed Mar 25 05:38:13 CDT 2020
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14010 )
Change subject: func_aes: Avoid incorrect error message on load.
......................................................................
Patch Set 1:
As a module func_aes requires res_crypto in order to work and be used. It uses functions provided by res_crypto. While the symbols may resolve even without res_crypto, they are merely stubs and not actually functional. I'm of the opinion that it is better to not allow the module to load at all since it wouldn't be functional.
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14010
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 17
Gerrit-Change-Id: I0b99b8468cbeb3b0eab23069cbd64062ef885ffc
Gerrit-Change-Number: 14010
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 10:38:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200325/7e3bf038/attachment.html>
More information about the asterisk-code-review
mailing list