[Asterisk-code-review] dundi: fix NULL dereference. (asterisk[master])

George Joseph asteriskteam at digium.com
Fri Mar 20 09:25:21 CDT 2020


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13948 )

Change subject: dundi:  fix NULL dereference.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Go ahead and cherry-pick once the snprintf format issue is addressed.

https://gerrit.asterisk.org/c/asterisk/+/13948/1/pbx/pbx_dundi.c 
File pbx/pbx_dundi.c:

https://gerrit.asterisk.org/c/asterisk/+/13948/1/pbx/pbx_dundi.c@4328 
PS1, Line 4328: u
Even though it will never be a negative number, this should probably be "%d" to match num_results.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13948
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5214ebb6491e2bd14f90c7d3ce229da86888f739
Gerrit-Change-Number: 13948
Gerrit-PatchSet: 1
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 20 Mar 2020 14:25:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200320/6a405b5d/attachment.html>


More information about the asterisk-code-review mailing list