[Asterisk-code-review] res_config_odbc: Preserve empty strings returned by the database (asterisk[16])

Joshua Colp asteriskteam at digium.com
Tue Mar 17 18:42:13 CDT 2020


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13710 )

Change subject: res_config_odbc: Preserve empty strings returned by the database
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> This patch changed behavior of ast_sorcery_object_field_register.
> In version 16.8.0 it doesn't matter if DB value is NULL or blank (""), sorcery sets default value.
> In version 16.9.0
> if the DB value is NULL then sorcery sets default value.
> if the DB value is blank then sorcery does not set default value.

Please file an issue, everything gets tracked there and comments like this on merged changes can end up getting lost.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13710
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I673ed8c31ad037aa224e80c78c7a1dc4e4a4e3de
Gerrit-Change-Number: 13710
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Comment-Date: Tue, 17 Mar 2020 23:42:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200317/85a5d0ff/attachment.html>


More information about the asterisk-code-review mailing list