[Asterisk-code-review] chan_vpb: Fix 'catching polymorphic type ... by value' error (asterisk[17])

George Joseph asteriskteam at digium.com
Tue Mar 17 07:37:22 CDT 2020


George Joseph has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/13965 )

Change subject: chan_vpb: Fix 'catching polymorphic type ... by value' error
......................................................................

chan_vpb: Fix 'catching polymorphic type ... by value' error

Fixes the following compile error:

    chan_vpb.cc:2688:26: error: catching polymorphic type
        ‘class std::exception’ by value

Change-Id: Ic87bc357d72427d77626735c83200fd278a7a649
---
M channels/chan_vpb.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved; Approved for Submit



diff --git a/channels/chan_vpb.cc b/channels/chan_vpb.cc
index e8cd961..fe99d5d 100644
--- a/channels/chan_vpb.cc
+++ b/channels/chan_vpb.cc
@@ -2691,7 +2691,7 @@
 	ast_format_cap_append(vpb_tech_indicate.capabilities, ast_format_slin, 0);
 	try {
 		num_cards = vpb_get_num_cards();
-	} catch (std::exception e) {
+	} catch (std::exception&) {
 		ast_log(LOG_ERROR, "No Voicetronix cards detected\n");
 		return AST_MODULE_LOAD_DECLINE;
 	}

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13965
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 17
Gerrit-Change-Id: Ic87bc357d72427d77626735c83200fd278a7a649
Gerrit-Change-Number: 13965
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200317/182dc503/attachment-0001.html>


More information about the asterisk-code-review mailing list