[Asterisk-code-review] dns_txt: Add TXT record parsing support (asterisk[master])

Sean Bright asteriskteam at digium.com
Thu Mar 12 07:11:45 CDT 2020


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13935 )

Change subject: dns_txt: Add TXT record parsing support
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13935/1/include/asterisk/dns_internal.h 
File include/asterisk/dns_internal.h:

https://gerrit.asterisk.org/c/asterisk/+/13935/1/include/asterisk/dns_internal.h@29 
PS1, Line 29: /*! \brief For AST_LIST */
> Ah, you added this because of existing code so that the code including this header brought it in automatically instead of the developer having to do, not because your new code used it.

I added it because dns_txt.c does not use any linked lists and should not have to include linkedlists.h in order to compile.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13935
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie0eca23b8e6f4c7d9846b6013d79099314d90ef5
Gerrit-Change-Number: 13935
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 12 Mar 2020 12:11:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean.bright at gmail.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200312/580eea04/attachment.html>


More information about the asterisk-code-review mailing list