[Asterisk-code-review] res_pjsip_sdp_rtp: Don't wait for ICE if not negotiated (asterisk[16])

Joshua Colp asteriskteam at digium.com
Mon Mar 9 05:34:59 CDT 2020


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13857 )

Change subject: res_pjsip_sdp_rtp: Don't wait for ICE if not negotiated
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13857/2/res/res_pjsip_sdp_rtp.c 
File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/c/asterisk/+/13857/2/res/res_pjsip_sdp_rtp.c@595 
PS2, Line 595: 		if (ice) {
ice will always exist here, as it returns above if it doesn't



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13857
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I17c137546dc9ecfb9583c24dcf4c2ced8bbd7a27
Gerrit-Change-Number: 13857
Gerrit-PatchSet: 2
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 09 Mar 2020 10:34:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200309/d0f1ccca/attachment.html>


More information about the asterisk-code-review mailing list