[Asterisk-code-review] chan_psip, res_pjsip_sdp_rtp: ignore rtptimeout if direct-media is ac... (asterisk[16])

Sean Bright asteriskteam at digium.com
Fri Mar 6 13:09:20 CST 2020


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13860 )

Change subject: chan_psip, res_pjsip_sdp_rtp: ignore rtptimeout if direct-media is active
......................................................................


Patch Set 1:

Question (because I haven't looked that closely at the code) - what about not calling this function at all if direct media is in use?


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13860
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I8b62012be7685849e8fb2b1c5dd39d35313ca2d1
Gerrit-Change-Number: 13860
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Neuhauser <mike at firmix.at>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 06 Mar 2020 19:09:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200306/fd5c1f65/attachment.html>


More information about the asterisk-code-review mailing list