[Asterisk-code-review] res_pjsip_session: Fixed wrong session termination (asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13806 )

Change subject: res_pjsip_session: Fixed wrong session termination
......................................................................


Patch Set 9:

(1 comment)

Thanks, I've fixed it.

https://gerrit.asterisk.org/c/asterisk/+/13806/7/res/res_pjsip_session.c 
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/13806/7/res/res_pjsip_session.c@3888 
PS7, Line 3888: 						delay_request(session, NULL, NULL, NULL, 0, DELAYED_METHOD_BYE, NULL);
> Why the delay_request here? This will place a BYE request into the delayed queue list to be executed […]
Agree, I've fixed.
I thought use the delay_request() is more safer than send a bye directly.
But yes, we have send the bye it here, directly.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13806
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifa864e0e125b1a7ed2f3abd4164187e1dddc56da
Gerrit-Change-Number: 13806
Gerrit-PatchSet: 9
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 06 Mar 2020 10:57:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200306/d0c1870c/attachment.html>