[Asterisk-code-review] res_rtp_asterisk: Add 'rtp show settings' cli command (asterisk[master])

Sean Bright asteriskteam at digium.com
Thu Mar 5 10:21:05 CST 2020


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13853 )

Change subject: res_rtp_asterisk: Add 'rtp show settings' cli command
......................................................................


Patch Set 2:

(4 comments)

https://gerrit.asterisk.org/c/asterisk/+/13853/2/res/res_rtp_asterisk.c 
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/13853/2/res/res_rtp_asterisk.c@8663 
PS2, Line 8663: 			"       Display settings configuration of the RTP\n";
Display RTP configuration settings


https://gerrit.asterisk.org/c/asterisk/+/13853/2/res/res_rtp_asterisk.c@8677 
PS2, Line 8677: 	ast_cli(a->fd, "  RTP Check sums:  %s\n", AST_CLI_YESNO(nochecksums == 0));
Checksums (one word)


https://gerrit.asterisk.org/c/asterisk/+/13853/2/res/res_rtp_asterisk.c@8678 
PS2, Line 8678: 	ast_cli(a->fd, "  DTFM Timeout:    %d\n", dtmftimeout);
DTMF


https://gerrit.asterisk.org/c/asterisk/+/13853/2/res/res_rtp_asterisk.c@8682 
PS2, Line 8682: 		ast_cli(a->fd, "  Probation :      %d\n", learning_min_sequential);
Change to:

 ast_cli(a->fd, "  Probation:       %d frames\n", learning_min_sequential);



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13853
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ibe5450898e2c3e1ed68c10993aa1ac6bf09b821f
Gerrit-Change-Number: 13853
Gerrit-PatchSet: 2
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 05 Mar 2020 16:21:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200305/03e118fb/attachment.html>


More information about the asterisk-code-review mailing list