[Asterisk-code-review] confbridge: Add pauses to sfu_add_remove_sources test. (testsuite[17])

Friendly Automation asteriskteam at digium.com
Wed Mar 4 06:16:57 CST 2020


Friendly Automation has submitted this change. ( https://gerrit.asterisk.org/c/testsuite/+/13865 )

Change subject: confbridge: Add pauses to sfu_add_remove_sources test.
......................................................................

confbridge: Add pauses to sfu_add_remove_sources test.

If a channel changes its stream topology quickly then
bridge_softmix will skip intermediary changes. This
change adds pauses to prevent this from happening.

Change-Id: I7889df80c39d31b602682a2826e4a694d1a71560
---
M tests/apps/confbridge/sfu_add_remove_sources/sipp/video_caller_second.xml
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/tests/apps/confbridge/sfu_add_remove_sources/sipp/video_caller_second.xml b/tests/apps/confbridge/sfu_add_remove_sources/sipp/video_caller_second.xml
index 39fba98..0e71557 100644
--- a/tests/apps/confbridge/sfu_add_remove_sources/sipp/video_caller_second.xml
+++ b/tests/apps/confbridge/sfu_add_remove_sources/sipp/video_caller_second.xml
@@ -156,6 +156,8 @@
     ]]>
   </send>
 
+  <pause milliseconds="5000"/>
+
   <send retrans="500">
     <![CDATA[
 
@@ -212,6 +214,8 @@
     ]]>
   </send>
 
+  <pause milliseconds="5000"/>
+
   <send retrans="500">
     <![CDATA[
 

-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/13865
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 17
Gerrit-Change-Id: I7889df80c39d31b602682a2826e4a694d1a71560
Gerrit-Change-Number: 13865
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200304/3f02b7f9/attachment.html>


More information about the asterisk-code-review mailing list