[Asterisk-code-review] res_pjsip_session: Fixed wrong session termination (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13806 )

Change subject: res_pjsip_session: Fixed wrong session termination
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13806/7/res/res_pjsip_session.c 
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/13806/7/res/res_pjsip_session.c@3888 
PS7, Line 3888: 						delay_request(session, NULL, NULL, NULL, 0, DELAYED_METHOD_BYE, NULL);
Why the delay_request here? This will place a BYE request into the delayed queue list to be executed later. It's possible for requests (such as a reinvite) to be ahead of it at that point. As well what triggers the delay request to occur in this scenario?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13806
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifa864e0e125b1a7ed2f3abd4164187e1dddc56da
Gerrit-Change-Number: 13806
Gerrit-PatchSet: 7
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 04 Mar 2020 11:25:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200304/4713f3c9/attachment.html>