[Asterisk-code-review] res_odbc.h: Added StrLen_or_IndPtr for use in SQLBindParameter (asterisk[16])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13851 )

Change subject: res_odbc.h: Added StrLen_or_IndPtr for use in SQLBindParameter
......................................................................


Patch Set 1:

This is definitely a bug in Ignite.
If StrLen_or_IndPtr is a null pointer, the Ignite assumes it SQL_DEFAULT_PARAM, but should be SQL_NTS.

--- ignite-master/modules/platforms/cpp/odbc/src/app/application_data_buffer.cpp        2020-03-03 11:30:21.000000000 -0500
+++ ignite-master-fix/modules/platforms/cpp/odbc/src/app/application_data_buffer.cpp    2020-03-03 13:18:52.012388301 -0500
@@ -1750,13 +1750,13 @@
             SqlLen ApplicationDataBuffer::GetInputSize() const
             {
                 if (!IsDataAtExec())
                 {
                     const SqlLen *len = GetResLen();
 
-                    return len ? *len : SQL_DEFAULT_PARAM;
+                    return len ? *len : SQL_NTS;
                 }
 
                 return GetDataAtExecSize();
             }
         }
     }


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13851
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia8c3fda14b9008e22fb4893204911259f600b32e
Gerrit-Change-Number: 13851
Gerrit-PatchSet: 1
Gerrit-Owner: Abhay Gupta <abhay at avissol.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Comment-Date: Tue, 03 Mar 2020 18:25:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200303/70b646bb/attachment.html>