[Asterisk-code-review] res_pjsip_session: Fixed wrong session termination (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13806 )

Change subject: res_pjsip_session: Fixed wrong session termination
......................................................................


Patch Set 7:

> Patch Set 7:
> 
> I think I was wrong. As @george mentioned it, I have the same question.
> 
> In case of unacceptable SDP with 200 OK, should be the UAC return the `CANCEL`?
> 
> Like this?
> 
> UAC       UAS
>  |-- INV ->|
>  |<- 100 --|
>  |<- 180 --|
>  |<- 200 --| But unacceptable SDP
>  |-CANCEL->|

200 OK is a final response, which means sending a CANCEL is not permitted and won't actually have an effect. Sending a BYE is the only way you can terminate the session at that point.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13806
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifa864e0e125b1a7ed2f3abd4164187e1dddc56da
Gerrit-Change-Number: 13806
Gerrit-PatchSet: 7
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 03 Mar 2020 10:12:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200303/160bdc33/attachment.html>