[Asterisk-code-review] res_rtp_asterisk: Improve video performance in certain networks. (asterisk[16])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13849 )

Change subject: res_rtp_asterisk: Improve video performance in certain networks.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13849/1/res/res_rtp_asterisk.c 
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/13849/1/res/res_rtp_asterisk.c@7660 
PS1, Line 7660: 		rtp->expectedrxseqno = seqno + 1;
              : 
              : 		/* We've cycled over, so go back to 0 */
              : 		if (rtp->expectedrxseqno == 65536) {
              : 			rtp->expectedrxseqno = 0;
              : 		}
Nothing to hold the review up, but the "inc" and check are done enough times throughout that a well named function for it might make sense.

Also I'd suggest adding a define for "65536".



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13849
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I97633dfa8a09a7889cef815b2be369f3f0314b41
Gerrit-Change-Number: 13849
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 02 Mar 2020 19:30:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200302/ec9c352b/attachment.html>