[Asterisk-code-review] message & stasis/messaging: make text message variables work in ARI (asterisk[17])

[Kevin Harwell]

Hello Joshua Colp, George Joseph, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/13839

to look at the new patch set (#4).

Change subject: message & stasis/messaging: make text message variables work in ARI
......................................................................

message & stasis/messaging: make text message variables work in ARI

When a text message was received any associated variable was not written to
the ARI TextMessageReceived event. This occurred because Asterisk only wrote
out "send" variables. However, even those "send" variables would fail ARI
validation due to a TextMessageVariable formatting bug.

Since it seems the TextMessageReceived event has never been able to include
actual variables it was decided to remove the TextMessageVariable object type
from ARI, and simply return a JSON object of key/value pairs for variables.
This aligns more with how the ARI sendMessage handles variables, and other
places in ARI.

That being the case, and since this is technically an API breaking change (no
one should really be affected since things never really worked) the ARI version
was updated to reflect that.

ASTERISK-28755 #close

Change-Id: Ia6051c01a53b30cf7edef84c27df4ed4479b8b6f
---
A doc/UPGRADE-staging/ari_messaging.txt
M include/asterisk/message.h
M main/message.c
M res/ari/ari_model_validators.c
M res/ari/ari_model_validators.h
M res/stasis/messaging.c
M rest-api/api-docs/endpoints.json
M rest-api/resources.json
8 files changed, 66 insertions(+), 109 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/39/13839/4
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13839
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 17
Gerrit-Change-Id: Ia6051c01a53b30cf7edef84c27df4ed4479b8b6f
Gerrit-Change-Number: 13839
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200302/28cd703a/attachment-0001.html>