[Asterisk-code-review] res_stir_shaken: Add stir_shaken option and general improvements. (asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14574 )

Change subject: res_stir_shaken: Add stir_shaken option and general improvements.
......................................................................


Patch Set 5: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/14574/5/configs/samples/stir_shaken.conf.sample 
File configs/samples/stir_shaken.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/14574/5/configs/samples/stir_shaken.conf.sample@17 
PS5, Line 17: ; Maximum time to wait to CURL certificates
In what time unit? Seconds?


https://gerrit.asterisk.org/c/asterisk/+/14574/5/configs/samples/stir_shaken.conf.sample@20 
PS5, Line 20: ; Amount of time a signature is valid for
In what time unit? Seconds?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14574
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I43d67f1489b8c1c5729ed3ca8d71e35ddf438df1
Gerrit-Change-Number: 14574
Gerrit-PatchSet: 5
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 30 Jun 2020 13:59:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200630/b5c7068e/attachment-0001.html>