[Asterisk-code-review] Streams: Add features for Advanced Codec Negotiation (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14577 )

Change subject: Streams:  Add features for Advanced Codec Negotiation
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/14577/3/main/stream.c 
File main/stream.c:

https://gerrit.asterisk.org/c/asterisk/+/14577/3/main/stream.c@130 
PS3, Line 130: 	struct ast_str *display_str;
> This can be removed now

I could swear I did that.


https://gerrit.asterisk.org/c/asterisk/+/14577/3/main/stream.c@1057 
PS3, Line 1057: 	return ao2_bump(joint_topology);
> Does this still need to ao2_bump?

Nope



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14577
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I2df77dedd0c72c52deb6e329effe057a8e06cd56
Gerrit-Change-Number: 14577
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 29 Jun 2020 17:56:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200629/9cf685b5/attachment.html>