[Asterisk-code-review] res_stir_shaken: Add @stir and add test conditions. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14574 )

Change subject: res_stir_shaken: Add @stir and add test conditions.
......................................................................


Patch Set 3:

> Patch Set 3: Code-Review-1
> 
> Not understanding the "@stir".  Why is this not a regular endpoint attribute that can be set in realtime?

I was wondering what thoughts would be for that. We can make it one, I originally documented it as an extended sorcery option on the design to remove the need to modify PJSIP at all.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14574
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I43d67f1489b8c1c5729ed3ca8d71e35ddf438df1
Gerrit-Change-Number: 14574
Gerrit-PatchSet: 3
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 29 Jun 2020 12:51:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200629/32d7a4f7/attachment-0001.html>