[Asterisk-code-review] res_pjsip.c: Added disable_rport option for pjsip.conf (asterisk[master])

sungtae kim asteriskteam at digium.com
Thu Jun 25 16:23:15 CDT 2020


sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14572 )

Change subject: res_pjsip.c: Added disable_rport option for pjsip.conf
......................................................................


Patch Set 2:

> Patch Set 1: Code-Review-1
> 
> (1 comment)
> 
> You'll need to create an alembic script to add this to the schema for ps_systems.
> A "CHANGES" entry would also be nice and it should also make clear that it's a global option.

Hi George,

Thank you for your reviewing. I've fixed it. 😊


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14572
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9596675e52a742774738b5aad5d1fec32f477abc
Gerrit-Change-Number: 14572
Gerrit-PatchSet: 2
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 25 Jun 2020 21:23:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200625/6a2a9c95/attachment.html>


More information about the asterisk-code-review mailing list