[Asterisk-code-review] menuselect: Resolve infinite loop in dependency scenario. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14573 )

Change subject: menuselect: Resolve infinite loop in dependency scenario.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14573/1/menuselect/menuselect.h 
File menuselect/menuselect.h:

https://gerrit.asterisk.org/c/asterisk/+/14573/1/menuselect/menuselect.h@82 
PS1, Line 82: 	unsigned int depsfailedold:2;
> Do we care about ABI here? I think this technically breaks it.
Menuselect itself is a self isolated application essentially, it doesn't present APIs or an interface for outside use so I thought it was fine.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14573
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Iea06d45d9fd6d8bfd068882a0bb7e23a53ec3e84
Gerrit-Change-Number: 14573
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Jaco Kroon <jaco at uls.co.za>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 25 Jun 2020 15:49:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200625/955a00fa/attachment.html>