[Asterisk-code-review] res_pjsip.c: Added disable_rport option for pjsip.conf (asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14572 )

Change subject: res_pjsip.c: Added disable_rport option for pjsip.conf
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> Rather than adding an option to disable rport, could we instead add an option to enable it that defaults to true?

Hi Sean, thank you for your replying.

I thought that too, but it looks like the breaking change to me.

Because of the Asterisk sent the "rport;" string all the time so far, if it just gone suddenly it could be breaking the other related system.

Btw, I'm fine change it to "true" as a default if you guys are ok too. 😊


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14572
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9596675e52a742774738b5aad5d1fec32f477abc
Gerrit-Change-Number: 14572
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 25 Jun 2020 14:49:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200625/99b488b9/attachment.html>