[Asterisk-code-review] chan_pjsip: don't use PJSIP_SC_NULL as it only exists pjproject 2.8+ (asterisk[master])

Joshua Colp asteriskteam at digium.com
Thu Jun 25 09:22:49 CDT 2020


Joshua Colp has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/14605 )

Change subject: chan_pjsip: don't use PJSIP_SC_NULL as it only exists pjproject 2.8+
......................................................................

chan_pjsip: don't use PJSIP_SC_NULL as it only exists pjproject 2.8+

A patch made a reference to the PJSIP_SC_NULL enumeration value, which
was added to pjproject 2.8 and above thus making it so Asterisk would
fail to compile with prior versions of pjproject.

This patch removes the reference, and instead initializes the value
to '0'.

ASTERISK-28886 #close

Change-Id: I68491c80da1a0154b2286c9458440141c98db9d7
---
M channels/chan_pjsip.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
  George Joseph: Looks good to me, approved



diff --git a/channels/chan_pjsip.c b/channels/chan_pjsip.c
index 45918ac..afaecdf 100644
--- a/channels/chan_pjsip.c
+++ b/channels/chan_pjsip.c
@@ -1993,7 +1993,7 @@
 		/* Check for NOTIFY complete or error. */
 		pjsip_msg *msg;
 		pjsip_msg_body *body;
-		pjsip_status_line status_line = { .code = PJSIP_SC_NULL };
+		pjsip_status_line status_line = { .code = 0 };
 		pj_bool_t is_last;
 		pj_status_t status;
 

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14605
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I68491c80da1a0154b2286c9458440141c98db9d7
Gerrit-Change-Number: 14605
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200625/ee3e7a7a/attachment.html>


More information about the asterisk-code-review mailing list