[Asterisk-code-review] res_pjsip.c: Added disable_rport option for pjsip.conf (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14572 )

Change subject: res_pjsip.c: Added disable_rport option for pjsip.conf
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

You'll need to create an alembic script to add this to the schema for ps_systems.
A "CHANGES" entry would also be nice and it should also make clear that it's a global option.

https://gerrit.asterisk.org/c/asterisk/+/14572/1//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/14572/1//COMMIT_MSG@1 
PS1, Line 1: Parent:     0c1c3866 (res_corosync: Fix crash in huge distributed environment.)
You should make it clear that this is a global option (even though it's in "system"), not on an endpoint-specific change.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14572
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9596675e52a742774738b5aad5d1fec32f477abc
Gerrit-Change-Number: 14572
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 25 Jun 2020 13:38:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200625/d39efea3/attachment-0001.html>