[Asterisk-code-review] res_http_websocket: Add payload masking to the websocket client (asterisk[master])

Nickolay V. Shmyrev asteriskteam at digium.com
Mon Jun 22 10:33:20 CDT 2020


Nickolay V. Shmyrev has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14520 )

Change subject: res_http_websocket: Add payload masking to the websocket client
......................................................................


Patch Set 4:

Moises, thank you for getting this merged, honestly gerrit is a bit over my head.

There is another big problem in asterisk websocket with ping/pong frames which you might catch too, see here:

https://issues.asterisk.org/jira/browse/ASTERISK-28958

Please let me know if you can take a look on it.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14520
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Id465030f2b1997b83d408933fdbabe01827469ca
Gerrit-Change-Number: 14520
Gerrit-PatchSet: 4
Gerrit-Owner: Moises Silva <moises.silva at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Nickolay V. Shmyrev <nshmyrev at alphacephei.com>
Gerrit-Comment-Date: Mon, 22 Jun 2020 15:33:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200622/c38abf0d/attachment.html>


More information about the asterisk-code-review mailing list