[Asterisk-code-review] res_http_websocket: Add payload masking to the websocket client (asterisk[master])

Nickolay V. Shmyrev asteriskteam at digium.com
Tue Jun 16 03:09:13 CDT 2020


Nickolay V. Shmyrev has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14520 )

Change subject: res_http_websocket: Add payload masking to the websocket client
......................................................................


Patch Set 2:

(1 comment)

One more fix

https://gerrit.asterisk.org/c/asterisk/+/14520/2/res/res_http_websocket.c 
File res/res_http_websocket.c:

https://gerrit.asterisk.org/c/asterisk/+/14520/2/res/res_http_websocket.c@335 
PS2, Line 335: 	res = ast_iostream_write(session->stream, frame, sizeof(frame));
Here for server case we shouldn't use sizeof(frame) anymore but 4 bytes since header is just 2. Below we shouldn't compare to sizeof(frame) as well.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14520
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Id465030f2b1997b83d408933fdbabe01827469ca
Gerrit-Change-Number: 14520
Gerrit-PatchSet: 2
Gerrit-Owner: Moises Silva <moises.silva at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Nickolay V. Shmyrev <nshmyrev at alphacephei.com>
Gerrit-Comment-Date: Tue, 16 Jun 2020 08:09:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200616/5c677a4f/attachment.html>


More information about the asterisk-code-review mailing list